Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemovedNodeVisitor should not remove imports when references exist. #264

Merged
merged 1 commit into from
Mar 16, 2020
Merged

RemovedNodeVisitor should not remove imports when references exist. #264

merged 1 commit into from
Mar 16, 2020

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Mar 16, 2020 •
edited
Loading

Summary

as title and was described in #258

Test Plan

New unit tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 16, 2020
@jimmylai jimmylai requested review from thatch and zsol March 16, 2020 05:31
@codecov-io
Copy link

Codecov Report

Merging #264 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   93.88%   93.89%           
=======================================
  Files         214      214           
  Lines       20818    20822    +4     
=======================================
+ Hits        19546    19550    +4     
  Misses       1272     1272
Impacted Files Coverage Δ
libcst/codemod/visitors/_remove_imports.py 93.12% <100.00%> (-0.13%) ⬇️
...bcst/codemod/visitors/tests/test_remove_imports.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8619a...c25197b. Read the comment docs.

thatch
thatch approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@thatch thatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jimmylai jimmylai merged commit f612604 into Instagram:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatch thatch thatch approved these changes

@zsol zsol Awaiting requested review from zsol

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimmylai @codecov-io @thatch @facebook-github-bot